Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump browserify-sign from 4.2.1 to 4.2.2 in /extentions/neo3-visual-tracker #382

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 25, 2023

Bumps browserify-sign from 4.2.1 to 4.2.2.

Changelog

Sourced from browserify-sign's changelog.

v4.2.2 - 2023-10-25

Fixed

Commits

  • Only apps should have lockfiles 09a8995
  • [eslint] switch to eslint 83fe463
  • [meta] add npmignore and auto-changelog 4418183
  • [meta] fix package.json indentation 9ac5a5e
  • [Tests] migrate from travis to github actions d845d85
  • [Fix] sign: throw on unsupported padding scheme 8767739
  • [Fix] properly check the upper bound for DSA signatures 85994cd
  • [Tests] handle openSSL not supporting a scheme f5f17c2
  • [Deps] update bn.js, browserify-rsa, elliptic, parse-asn1, readable-stream, safe-buffer a67d0eb
  • [Dev Deps] update nyc, standard, tape cc5350b
  • [Tests] always run coverage; downgrade nyc 75ce1d5
  • [meta] add safe-publish-latest dcf49ce
  • [Tests] add npm run posttest 75dd8fd
  • [Dev Deps] update tape 3aec038
  • [Tests] skip unsupported schemes 703c83e
  • [Tests] node < 6 lacks array includes 3aa43cf
  • [Dev Deps] fix eslint range 98d4e0d
Commits
  • 4af5a90 v4.2.2
  • 3aec038 [Dev Deps] update tape
  • 85994cd [Fix] properly check the upper bound for DSA signatures
  • 9ac5a5e [meta] fix package.json indentation
  • dcf49ce [meta] add safe-publish-latest
  • 4418183 [meta] add npmignore and auto-changelog
  • 8767739 [Fix] sign: throw on unsupported padding scheme
  • 5f6fb17 [Tests] log when openssl doesn't support cipher
  • f5f17c2 [Tests] handle openSSL not supporting a scheme
  • d845d85 [Tests] migrate from travis to github actions
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by ljharb, a new releaser for browserify-sign since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md)
- [Commits](browserify/browserify-sign@v4.2.1...v4.2.2)

---
updated-dependencies:
- dependency-name: browserify-sign
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 25, 2023
@Jim8y
Copy link
Contributor

Jim8y commented Nov 25, 2023

@Ashuaidehao @cschuchardt88 please check these bots pr call me if good to merge.

@cschuchardt88
Copy link
Member

@Ashuaidehao maybe you help me compile the extension?

I get this error:

PS C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker> npm run compile     

> [email protected] compile
> npm run compile-ext && npm run compile-panel


> [email protected] compile-ext
> webpack --config src/extension/webpack.config.js --mode development

C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\loader-runner\lib\LoaderRunner.js:146
                if(isError) throw e;
                            ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:68:19)
    at Object.createHash (node:crypto:138:10)
    at BulkUpdateDecorator.hashFactory (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\util\createHash.js:144:18)
    at BulkUpdateDecorator.update (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\util\createHash.js:46:50)
    at SourceMapSource.updateHash (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack-sources\lib\SourceMapSource.js:233:8)
    at NormalModule._initBuildHash (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\NormalModule.js:853:17)
    at handleParseResult (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\NormalModule.js:918:10)
    at C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\NormalModule.js:1009:4
    at processResult (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\NormalModule.js:732:11)
    at C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\NormalModule.js:792:5 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

Node.js v20.9.0
PS C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker>

@cschuchardt88
Copy link
Member

@Liaojinghui looks like this breaks the build. I was able to compile fine on master

@Jim8y
Copy link
Contributor

Jim8y commented Nov 27, 2023

@Ashuaidehao maybe you help me compile the extension?

I get this error:

PS C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker> npm run compile     

> [email protected] compile
> npm run compile-ext && npm run compile-panel


> [email protected] compile-ext
> webpack --config src/extension/webpack.config.js --mode development

C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\loader-runner\lib\LoaderRunner.js:146
                if(isError) throw e;
                            ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:68:19)
    at Object.createHash (node:crypto:138:10)
    at BulkUpdateDecorator.hashFactory (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\util\createHash.js:144:18)
    at BulkUpdateDecorator.update (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\util\createHash.js:46:50)
    at SourceMapSource.updateHash (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack-sources\lib\SourceMapSource.js:233:8)
    at NormalModule._initBuildHash (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\NormalModule.js:853:17)
    at handleParseResult (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\NormalModule.js:918:10)
    at C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\NormalModule.js:1009:4
    at processResult (C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\NormalModule.js:732:11)
    at C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker\node_modules\webpack\lib\NormalModule.js:792:5 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

Node.js v20.9.0
PS C:\Users\Chris\Projects\cschuchardt88\neo-express\extentions\neo3-visual-tracker>

@Ashuaidehao any update on this?

@cschuchardt88
Copy link
Member

I haven't had time to fix. Dont know webpack to well. If you want to give it a go you can. I was going to see if we can get neo-project/neo-modules#847 to be added, so we can update the extension to use WebSockets. Would be more stable.

@Ashuaidehao
Copy link
Collaborator

Ashuaidehao commented Nov 28, 2023

I have no ideas about node, too. Maybe because my node version is lower?
I found the old build workflow was set to node v16.
图片

@Jim8y
Copy link
Contributor

Jim8y commented Nov 28, 2023

Issues being fixed now. its about 1. node.js version. 2. missing dependency. 3. exception type.

@Jim8y Jim8y merged commit 4c1c513 into master Nov 28, 2023
2 checks passed
@Jim8y Jim8y deleted the dependabot/npm_and_yarn/extentions/neo3-visual-tracker/browserify-sign-4.2.2 branch November 28, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants