Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC-JSON over WebSockets #847
RPC-JSON over WebSockets #847
Changes from 1 commit
0f70f8d
e2de661
35d7c70
983d543
528e1ca
cf968be
5a76fab
9410d92
665e4f5
e5a0e29
8c8f611
8e1c9f7
e20e84c
ec72689
8d10b0c
5df1de0
03015d7
5acf717
2f8d05f
67e0f91
fc67dee
f21c286
4bc67df
2597889
8b240b5
207fe70
f54ed8f
86d915d
3d999cb
baaccad
b7af661
19b8da6
987dc46
8e53db8
f6ff6a8
53cefdf
3bb4306
1832fd8
8dcb91e
074649f
8927853
32a867e
1ec7644
ecbb806
307d263
23d9a34
ac6526f
580b864
7d8f492
35675e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change this back.
WebSocketClient
is abase
class. You can extend the class by inheriting it. For example if you want to add more properties/fields or methods to it. Like a tracking number or Client's login information.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I program dynamically and make things reuse able.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can extend WebSocketClient, we don't need more types of WebSocketClients, sometimes simpler is better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes in theory. But this also limits the API or makes more work in the future. If the code is already there or built for reusability, than the code should stay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not agree, we don't need two WebSocketClients