[Neo Plugin RpcServer UT]Plugin rpcserver wallet UTs (#3433)

* wallet * fix util * add comments and fix ut * Update tests/Neo.Plugins.RpcServer.Tests/UT_RpcServer.Wallet.cs * remove comment --------- Co-authored-by: Christopher Schuchardt <[email protected]> Co-authored-by: Shargon <[email protected]> Co-authored-by: NGD Admin <[email protected]>
neo-project · Jul 29, 2024 · c2141e8 · c2141e8
1 parent eb167b3
commit c2141e8
Show file tree

Hide file tree

Showing 7 changed files with 785 additions and 204 deletions.
diff --git a/src/Plugins/RpcServer/Result.cs b/src/Plugins/RpcServer/Result.cs
@@ -23,7 +23,7 @@ public static class Result
         /// <typeparam name="T">The return type</typeparam>
         /// <returns>The execution result</returns>
         /// <exception cref="RpcException">The Rpc exception</exception>
-        public static T Ok_Or<T>(this Func<T> function, RpcError err, bool withData = false)
+        public static T Ok_Or<T>(Func<T> function, RpcError err, bool withData = false)
         {
             try
             {

diff --git a/src/Plugins/RpcServer/RpcServer.SmartContract.cs b/src/Plugins/RpcServer/RpcServer.SmartContract.cs
@@ -213,7 +213,7 @@ private static Witness[] WitnessesFromJson(JArray _params)
         }
 
         [RpcMethod]
-        protected virtual JToken InvokeFunction(JArray _params)
+        protected internal virtual JToken InvokeFunction(JArray _params)
         {
             UInt160 script_hash = Result.Ok_Or(() => UInt160.Parse(_params[0].AsString()), RpcError.InvalidParams.WithData($"Invalid script hash {nameof(script_hash)}"));
             string operation = Result.Ok_Or(() => _params[1].AsString(), RpcError.InvalidParams);
@@ -231,7 +231,7 @@ protected virtual JToken InvokeFunction(JArray _params)
         }
 
         [RpcMethod]
-        protected virtual JToken InvokeScript(JArray _params)
+        protected internal virtual JToken InvokeScript(JArray _params)
         {
             byte[] script = Result.Ok_Or(() => Convert.FromBase64String(_params[0].AsString()), RpcError.InvalidParams);
             Signer[] signers = _params.Count >= 2 ? SignersFromJson((JArray)_params[1], system.Settings) : null;
@@ -241,7 +241,7 @@ protected virtual JToken InvokeScript(JArray _params)
         }
 
         [RpcMethod]
-        protected virtual JToken TraverseIterator(JArray _params)
+        protected internal virtual JToken TraverseIterator(JArray _params)
         {
             settings.SessionEnabled.True_Or(RpcError.SessionsDisabled);
             Guid sid = Result.Ok_Or(() => Guid.Parse(_params[0].GetString()), RpcError.InvalidParams.WithData($"Invalid session id {nameof(sid)}"));
@@ -262,7 +262,7 @@ protected virtual JToken TraverseIterator(JArray _params)
         }
 
         [RpcMethod]
-        protected virtual JToken TerminateSession(JArray _params)
+        protected internal virtual JToken TerminateSession(JArray _params)
         {
             settings.SessionEnabled.True_Or(RpcError.SessionsDisabled);
             Guid sid = Result.Ok_Or(() => Guid.Parse(_params[0].GetString()), RpcError.InvalidParams.WithData("Invalid session id"));
@@ -278,7 +278,7 @@ protected virtual JToken TerminateSession(JArray _params)
         }
 
         [RpcMethod]
-        protected virtual JToken GetUnclaimedGas(JArray _params)
+        protected internal virtual JToken GetUnclaimedGas(JArray _params)
         {
             string address = Result.Ok_Or(() => _params[0].AsString(), RpcError.InvalidParams.WithData($"Invalid address {nameof(address)}"));
             JObject json = new();

diff --git a/src/Plugins/RpcServer/RpcServer.Wallet.cs b/src/Plugins/RpcServer/RpcServer.Wallet.cs