Fix plugin exception #3426
Merged
Fix plugin exception #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject#3366)" This reverts commit f307a31.
…roject#3366)" This reverts commit f307a31.
Co-authored-by: Christopher Schuchardt <[email protected]>
…plugin-exception * 'fix-plugin-exception' of github.com:Jim8y/neo: Update src/Neo/Plugins/UnhandledExceptionPolicy.cs ensure leveldb is not used in multithread env Revert "Revert "Plugin unhandled exception (neo-project#3349)" (neo-project#3366)" # Conflicts: # src/Neo/Ledger/Blockchain.cs # src/Neo/Plugins/UnhandledExceptionPolicy.cs # tests/Neo.UnitTests/Plugins/TestPlugin.cs # tests/Neo.UnitTests/Plugins/UT_Plugin.cs
Co-authored-by: Christopher Schuchardt <[email protected]>
cschuchardt88
previously approved these changes
Jul 23, 2024
shargon
reviewed
Jul 24, 2024
| @@ -3,7 +3,8 @@ | |||
| "Path": "ApplicationLogs_{0}", | |||
| "Network": 860833102, | |||
| "MaxStackSize": 65535, | |||
| "Debug": false | |||
| "Debug": false, | |||
| "UnhandledExceptionPolicy": "StopPlugin" | |||
There was a problem hiding this comment.
I think it's better in almost all of them StopNode by default, is the current behaviour
There was a problem hiding this comment.
nothoing was changed since the last review but the deledage invoke. Different plugin has different behavior on unhandled exception that are precisely set by superboy. Default behavior means nothing here.
shargon
reviewed
Jul 24, 2024
shargon
reviewed
Jul 24, 2024
cschuchardt88
previously approved these changes
Jul 25, 2024
Co-authored-by: Shargon <[email protected]>
shargon
approved these changes
Jul 29, 2024
cschuchardt88
approved these changes
Aug 1, 2024
vncoelho
reviewed
Aug 1, 2024
| using System.Collections.Generic; | ||
| using System.Collections.Immutable; | ||
| using System.Diagnostics; | ||
| using System.Linq; | ||
| using System.Threading.Tasks; | ||
| using System.Runtime.CompilerServices; |
There was a problem hiding this comment.
What we have this requirement added?
vncoelho
approved these changes
Aug 1, 2024
vncoelho
reviewed
Aug 1, 2024
| // skip stopped plugin. | ||
| if (handler.Target is Plugin { IsStopped: true }) | ||
| { | ||
| continue; |
There was a problem hiding this comment.
if the stopped plugin keep crashing nothing will be reported?
vncoelho
reviewed
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr reopens the plugin unhandled exception pr, and fixed the async delegate invocation calling.
Fixes # #3356
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: