[Neo Core Exception] Create WalletException and use it to replace all exceptions in wallet

src/Neo/Wallets/Wallet.cs

@@ -706,7 +706,7 @@
 
                     // Try Smart contract verification
 
-                    var contract = NativeContract.ContractManagement.GetContract(context.Snapshot, scriptHash);
+                var contract = NativeContract.ContractManagement.GetContract(context.SnapshotCache, scriptHash);
 
                     if (contract != null)
                     {

tests/Neo.UnitTests/Network/P2P/Payloads/UT_Transaction.cs

@@ -578,7 +578,7 @@ public void FeeIsSignatureContract_TestScope_CurrentHash_NEO_FAULT()
             // expects FAULT on execution of 'transfer' Application script
             // due to lack of a valid witness validation
             Transaction tx = null;
-            var exception = Assert.ThrowsException<WalletException>(() => tx = wallet.MakeTransaction(snapshot, script, acc.ScriptHash, signers));
+            var exception = Assert.ThrowsException<WalletException>(() => tx = wallet.MakeTransaction(snapshotCache, script, acc.ScriptHash, signers));
             Assert.AreEqual(exception.ErrorType, WalletErrorType.ExecutionFault);
             Assert.IsNull(tx);
         }
@@ -710,7 +710,7 @@ public void FeeIsSignatureContract_TestScope_NoScopeFAULT()
             // expects FAULT on execution of 'transfer' Application script
             // due to lack of a valid witness validation
             Transaction tx = null;
-            var exception = Assert.ThrowsException<WalletException>(() => tx = wallet.MakeTransaction(snapshot, script, acc.ScriptHash, signers, attributes));
+            var exception = Assert.ThrowsException<WalletException>(() => tx = wallet.MakeTransaction(snapshotCache, script, acc.ScriptHash, signers, attributes));
             Assert.AreEqual(exception.ErrorType, WalletErrorType.ExecutionFault);
             Assert.IsNull(tx);
         }
@@ -761,7 +761,7 @@ public void FeeIsSignatureContract_UnexistingVerificationContractFAULT()
             // expects ArgumentException on execution of 'CalculateNetworkFee' due to
             // null witness_script (no account in the wallet, no corresponding witness
             // and no verification contract for the signer)
-            var exception = Assert.ThrowsException<WalletException>(() => walletWithoutAcc.MakeTransaction(snapshot, script, acc.ScriptHash, signers));
+            var exception = Assert.ThrowsException<WalletException>(() => walletWithoutAcc.MakeTransaction(snapshotCache, script, acc.ScriptHash, signers));
             Assert.AreEqual(exception.ErrorType, WalletErrorType.ContractNotFound);
             Assert.IsNull(tx);
         }
@@ -1017,7 +1017,7 @@ public void FeeIsSignatureContract_TestScope_FeeOnly_Default()
                     Scopes =  WitnessScope.None
                 } };
 
-            var exception = Assert.ThrowsException<WalletException>(() => wallet.MakeTransaction(snapshot, script, acc.ScriptHash, signers));
+            var exception = Assert.ThrowsException<WalletException>(() => wallet.MakeTransaction(snapshotCache, script, acc.ScriptHash, signers));
             Assert.AreEqual(exception.ErrorType, WalletErrorType.ExecutionFault);
 
             // change to global scope

tests/Neo.UnitTests/Wallets/UT_AssetDescriptor.cs

@@ -23,10 +23,10 @@ public class UT_AssetDescriptor
         [TestMethod]
         public void TestConstructorWithNonexistAssetId()
         {
-            var snapshot = TestBlockchain.GetTestSnapshotCache();
+            var snapshotCache = TestBlockchain.GetTestSnapshotCache();
             var exception = Assert.ThrowsException<WalletException>(() =>
             {
-                var descriptor = new Neo.Wallets.AssetDescriptor(snapshot, TestProtocolSettings.Default, UInt160.Parse("01ff00ff00ff00ff00ff00ff00ff00ff00ff00a4"));
+                var descriptor = new Neo.Wallets.AssetDescriptor(snapshotCache, TestProtocolSettings.Default, UInt160.Parse("01ff00ff00ff00ff00ff00ff00ff00ff00ff00a4"));
             });
             Assert.AreEqual(exception.ErrorType, WalletErrorType.ContractNotFound);
         }

tests/Neo.UnitTests/Wallets/UT_Wallet.cs

@@ -296,7 +296,7 @@ public void TestMakeTransaction1()
             WalletAccount account = wallet.CreateAccount(contract, glkey.PrivateKey);
             account.Lock = false;
 
-            var exception = Assert.ThrowsException<WalletException>(() => wallet.MakeTransaction(snapshot, new TransferOutput[]
+            var exception = Assert.ThrowsException<WalletException>(() => wallet.MakeTransaction(snapshotCache, new TransferOutput[]
             {
                 new TransferOutput()
                 {
@@ -308,7 +308,7 @@ public void TestMakeTransaction1()
             }, UInt160.Zero));
             Assert.AreEqual(exception.ErrorType, WalletErrorType.InsufficientFunds);
 
-            exception = Assert.ThrowsException<WalletException>(() => wallet.MakeTransaction(snapshot, new TransferOutput[]
+            exception = Assert.ThrowsException<WalletException>(() => wallet.MakeTransaction(snapshotCache, new TransferOutput[]
             {
                 new TransferOutput()
                 {
@@ -319,8 +319,7 @@ public void TestMakeTransaction1()
                 }
             }, account.ScriptHash));
             Assert.AreEqual(exception.ErrorType, WalletErrorType.InsufficientFunds);
-
-            exception = Assert.ThrowsException<WalletException>(() => wallet.MakeTransaction(snapshot, new TransferOutput[]
+            exception = Assert.ThrowsException<WalletException>(() => wallet.MakeTransaction(snapshotCache, new TransferOutput[]
             {
                 new TransferOutput()
                 {
@@ -375,7 +374,7 @@ public void TestMakeTransaction2()
         {
             var snapshotCache = TestBlockchain.GetTestSnapshotCache();
             MyWallet wallet = new();
-            var exception = Assert.ThrowsException<WalletException>(() => wallet.MakeTransaction(snapshot, Array.Empty<byte>(), null, null, Array.Empty<TransactionAttribute>()));
+            var exception = Assert.ThrowsException<WalletException>(() => wallet.MakeTransaction(snapshotCache, Array.Empty<byte>(), null, null, Array.Empty<TransactionAttribute>()));
             Assert.AreEqual(exception.ErrorType, WalletErrorType.InsufficientFunds);
 
             Contract contract = Contract.Create(new ContractParameterType[] { ContractParameterType.Boolean }, new byte[] { 1 });