Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardofork HF_Echidna #3454

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add hardofork HF_Echidna #3454

wants to merge 3 commits into from

Conversation

@Jim8y Jim8y added the blocked This issue can't be worked at the moment label Aug 7, 2024
@Jim8y Jim8y marked this pull request as draft August 7, 2024 16:44
@@ -40,7 +40,8 @@
"HF_Aspidochelone": 3000000,
"HF_Basilisk": 4500000,
"HF_Cockatrice": 5800000,
"HF_Domovoi": 5800000
"HF_Domovoi": 5800000,
"HF_Echidna": 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to plan when we're going to have the next release. May be we can postpone configuration changes until some real proximity to the release and in this PR add only HF_Echidna enum?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to plan when we're going to have the next release. May be we can postpone configuration changes until some real proximity to the release and in this PR add only HF_Echidna enum?

Its placeholder, can be updated before merge to the master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make configs stored in the master branch unusable for real synchronization for some time, nothing good about that. Better omit it, declare HF_Echidna (we need it and will use it), but update configs later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make configs stored in the master branch unusable for real synchronization for some time, nothing good about that. Better omit it, declare HF_Echidna (we need it and will use it), but update configs later.

this will not be merged to the master branch until we decides to release new version.

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count
@Jim8y Jim8y added this to the v3.8.0 milestone Aug 8, 2024
* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue can't be worked at the moment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants