[Neo Core Style] update smartcontract struct and name

[Jim8y]

Description

Currently different group of files are put together under the network payload and smart contract, making it hard to understand the payload structure. And same files are not named properly, such as Conflicts is actually ConflictAttribute. Thus having this pr that update the files position to properly group them, and also rename some class to properly reflect its purpose.

In this pr, no logic has being changed.

Fixes # (issue)

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Test Configuration:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[shargon]

Maybe we should also move the namespaces, have some files with the namespace according to the folder, and others don't seems weird

[Jim8y]

Maybe we should also move the namespaces, have some files with the namespace according to the folder, and others don't seems weird

Namespace has being a problem in every core project and almost every file, you can have a seperate pr to focus on that issue if you think it should be fixed.

[shargon]

I'm not against the pr, but it changes a public class, so maybe we can also remove some obsolete calls because we will need a new version

[AnnaShaleva]

No functional changes, but is neo-devpack or other dependent tools affected by this renaming? If so, then I agree with @shargon, some transition period is needed. If no one uses these classes except the core, then it may be merged as is.

[cschuchardt88]

The naming is still bad ConflictAttribute name suggests that its uses the Attribute class in dotnet or an attribute for a field, property or method. Putting it under a namespace named Neo.Network.P2P.Payloads.Witness.Attributes with the name Conflict is more suitable. Plus seeing how the class is still public, no need to make it obsolete. Developers know when from version to version code, namespace, methods and etc can change. I see this being no part. Because you have to nuget new version and compile. Compiling will fail yes, but doesn't block or stop them from changing it.

[Jim8y]

No functional changes, but is neo-devpack or other dependent tools affected by this renaming? If so, then I agree with @shargon, some transition period is needed. If no one uses these classes except the core, then it may be merged as is.

@AnnaShaleva @shargon can you please check if the update works. Just add them back but mark as obsolete.

[AnnaShaleva]

Otherwise LGTM.

[AnnaShaleva]

Useless change.

[Jim8y]

I think this may cause by my dotnet format.

[AnnaShaleva]

Not fixed.

[Jim8y]

please focus on functionality.

[shargon]

Before remove maybe is easier to mantain if we share the code

Suggested change

	public class Conflicts : TransactionAttribute
	public class Conflicts : ConflictsAttribute

[cschuchardt88]

@shargon thats what i said here #3488 (comment)

[Jim8y]

Before remove maybe is easier to mantain if we share the code

But code is already there, keep this pr this way as much easier isn't it~~~~

[AnnaShaleva]

Please, take care of src/Neo/Builders/TransactionAttributesBuilder.cs and benchmarks/Neo.VM.Benchmarks/Benchmarks.Types.cs, because these classes use obsolete attributes; we need to replace them with the new ones.

[AnnaShaleva]

Not fixed.

[Jim8y]

too many non-functional suggestions that make it hard to maintain this pr, thus close to save my effort.