Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added equals to ContractMethodDescriptor #3570

Merged
merged 10 commits into from
Nov 11, 2024
Merged

Added equals to ContractMethodDescriptor #3570

merged 10 commits into from
Nov 11, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Nov 9, 2024

Description

Added some equals to ContractMethodDescriptor

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • EqualTests

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon requested a review from Jim8y November 9, 2024 10:02
@shargon shargon added Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. Waiting for Review labels Nov 9, 2024
@shargon shargon marked this pull request as ready for review November 9, 2024 10:03
Jim8y
Jim8y previously approved these changes Nov 9, 2024
@shargon shargon changed the title Added some equals Added equals to ContractMethodDescriptor Nov 11, 2024
@shargon
Copy link
Member Author

shargon commented Nov 11, 2024

@cschuchardt88 @Jim8y merge?

@shargon shargon requested a review from Jim8y November 11, 2024 13:18
@shargon shargon merged commit 233d0b0 into master Nov 11, 2024
7 checks passed
@shargon shargon deleted the some-equals branch November 11, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants