-
Notifications
You must be signed in to change notification settings - Fork 1k
[Fix] UPnP Discover
#4235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[Fix] UPnP Discover
#4235
Conversation
src/Neo/Network/Messages/Requests/GetExternalIPAddressRequestMessage.cs
Outdated
Show resolved
Hide resolved
|
There is no a good external nuget for UPnp? |
I rather have control of the code myself unless it's Microsoft. Because problems need to be fixed immediately. And less bloat code. @Jim8y can you test on |
|
In my opinion, we can remove UPnP support. It's something the network administrator should handle. Perhaps they don't want to open the ports to the outside, and we opened them without asking. Besides, it's a complex protocol that's completely unrelated to the node. What do you think @erikzhang? |
Description
The current
UPnPis so old that it doesn't work correctly!!!! Wrote a newUPnPsearcher to apply the node's open port on all devices and interfaces.Type of change
How Has This Been Tested?
Checklist: