Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo Address Resolution #133

Merged
merged 3 commits into from
May 26, 2024
Merged

Neo Address Resolution #133

merged 3 commits into from
May 26, 2024

Conversation

erikzhang
Copy link
Member

No description provided.

@steven1227
Copy link
Member

Why not put Neo addresses in NNS directly?

@erikzhang
Copy link
Member Author

Why not put Neo addresses in NNS directly?

As I've answered in neo-project/neo#2284 (comment):

My design philosophy is to design a lightweight core as much as possible. For problems that can be solved with standards, try not to add functions to the core. Unless this can bring very obvious advantages, such as performance improvements.

shargon
shargon previously approved these changes Feb 14, 2021
@roman-khimov
Copy link
Contributor

roman-khimov commented Sep 13, 2022

NEP-1 as it is now:

If the NEP collaborators approve, the NEP editor will assign the NEP a number, label it as Standards Track, Informational, or Meta, give it status "Draft", and add it to the git repository.

Once the NEP is ready for the repository, the NEP editor will:
...
Merge the pull request...
List the NEP in README.mediawiki

But we have this one, #134 and #145 with an "Accepted" status, listed in README and yet not merged into the repository. Is this correct from the process POV? I think we should merge them at least. If any changes needed they can be done in separate PRs until these NEPs reach "Final" status. And then "Final" NEPs MUST NOT be touched except for grammar, spelling, or markup mistakes. Maybe we want to update NEP-1 with this?

@Jim8y
Copy link
Contributor

Jim8y commented Mar 10, 2024

@shargon should we merge the accepted proposal?

@shargon
Copy link
Member

shargon commented Mar 12, 2024

@shargon should we merge the accepted proposal?

Yes, we are all agree? please vote with 👍 or 👎

@roman-khimov
Copy link
Contributor

We will provide some examples afterwards, we're storing contract hashes in NNS already.

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And where is the domain name?

@vncoelho
Copy link
Member

This is just for the address themself? no directly relation to the domain that will be linked, right?

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roman-khimov maybe we should use address.N3= ?

@roman-khimov
Copy link
Contributor

I don't think it's worth the trouble. Legacy is almost non-existent to me and it's easily separated from N3 because of A prefix.

@shargon
Copy link
Member

shargon commented Mar 15, 2024

I don't think it's worth the trouble. Legacy is almost non-existent to me and it's easily separated from N3 because of A prefix.

But you can store ethereum address o bane address also...

@cschuchardt88
Copy link
Member

cschuchardt88 commented Mar 15, 2024

I think this should function like DNS.

I don't think it's worth the trouble. Legacy is almost non-existent to me and it's easily separated from N3 because of A prefix.

But you can store ethereum address o bane address also...

The hostname for the txt record would be whatever format the validator wants. This would provide ownership validation.

Example

hostname Record Type Value
ether-challenge TXT "address=0x26FfB57236FeA81746c9a1f2604fEB7ec1Bb4BDC"

@roman-khimov
Copy link
Contributor

But you can store ethereum address o bane address also...

The way the NEP author wanted it is #133 (comment). To me it's acceptable, having this standard as it is now it better than not having it at all.

@superboyiii
Copy link
Member

superboyiii commented Apr 3, 2024

Better than nothing. Let's vote for merge. @shargon @roman-khimov @AnnaShaleva @Jim8y @shargon @AnnaShaleva

@Jim8y
Copy link
Contributor

Jim8y commented Apr 3, 2024

Man, you have to tell us how to vote @superboyiii

@Jim8y Jim8y requested a review from a team May 24, 2024 02:40
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to vote neutral as well? For me this is kind of neutral.

@Jim8y
Copy link
Contributor

Jim8y commented May 24, 2024

How to vote neutral as well? For me this is kind of neutral.

yes or no man please, decisions must be made.

@Jim8y
Copy link
Contributor

Jim8y commented May 24, 2024

But isn't this one already marked as accepetd?

@cschuchardt88
Copy link
Member

After this can we make reverse lookup for new type PTR

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely worth merging, it might be helpful for NeoFS.

@Jim8y Jim8y merged commit 69ccc34 into master May 26, 2024
@Jim8y Jim8y deleted the nns-txt-address branch May 26, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants