Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/715 expand loses node text #715 #1004

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hlin-neo4j
Copy link

#715
Added a boolean additive to control when to default the selections to the old selection first before proceeding with getting the other selections based on fields.

Maybe I can remove the boolean and have the getSelectionBasedOnFields function to always initially use the oldSelection first? For example, I expand a node on the graph report that reveals new labels > I set selections for new labels > I trigger rerun of the graph report's query from another Card. If those nodes with the new labels I recently set selections for come back, I'd expect those selections to persist. In this case, I should also have to pass in true for additive in the setSchema arguments in Report.tsx:populateReport function. Are there any situations where getSelectionBasedOnFields shouldn't default to oldSelection first?

Copy link

sonarcloud bot commented Nov 27, 2024

@hlin-neo4j hlin-neo4j changed the base branch from master to develop November 27, 2024 15:43
@alfredorubin96 alfredorubin96 added the 2.4.10 For this release label Nov 27, 2024
@hlin-neo4j hlin-neo4j changed the title Fix/715 expand loses node text Fix/715 expand loses node text #715 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.10 For this release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants