Fix/715 expand loses node text #715 #1004
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#715
Added a boolean
additive
to control when to default the selections to the old selection first before proceeding with getting the other selections based on fields.Maybe I can remove the boolean and have the getSelectionBasedOnFields function to always initially use the oldSelection first? For example, I expand a node on the graph report that reveals new labels > I set selections for new labels > I trigger rerun of the graph report's query from another Card. If those nodes with the new labels I recently set selections for come back, I'd expect those selections to persist. In this case, I should also have to pass in
true
for additive in the setSchema arguments in Report.tsx:populateReport function. Are there any situations where getSelectionBasedOnFields shouldn't default to oldSelection first?