Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value.low existence check when value is not an Object #1008

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

bastienhubert
Copy link
Collaborator

@bastienhubert bastienhubert commented Nov 28, 2024

Fixing issue linked to PR #951

@bastienhubert bastienhubert added the bug Something isn't working label Nov 28, 2024
@bastienhubert bastienhubert self-assigned this Nov 28, 2024
@bastienhubert bastienhubert linked an issue Nov 28, 2024 that may be closed by this pull request
@nielsdejong nielsdejong added the 2.4.10 For this release label Nov 28, 2024
@JonanOribe
Copy link
Contributor

Hi @bastienhubert, I just encountered this error today and I have come to the same solution as you, so we have double check. Good job!

@bastienhubert
Copy link
Collaborator Author

Thanks for the feedback @JonanOribe ! :)

@bastienhubert
Copy link
Collaborator Author

Duplicated by #1012, still need a review

@alfredorubin96 alfredorubin96 merged commit eddc9ba into develop Feb 10, 2025
2 checks passed
@alfredorubin96 alfredorubin96 deleted the fix/951-download-csv branch February 10, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.10 For this release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV download is broken on NeoDash 2.4.9
4 participants