Vulcan 134/configurable attributes review

[nielsdejong]

Replacement for #645

---

Ordering and Hide features of graph attributes in detail view

• When user clicks on one node/edge. In the detail popup, Our users wanted few attributes to display in defined order and other attributes which are there will be displayed in ascending order.

{
         "id": "6d00f7c7-4b3d-4b6d-9224-2b61fb0c129a",
         "title": "Movie",
         "query": "MATCH (n)-[e]->(m) RETURN n,e,m LIMIT 20\n\n\n",
         ....
         "settings": {
           "customTablePropertiesOfModal": [
               {
                 "type": "node",
                 "entityType": "Movie",
                 "ordering": ["title", "tagline"],
                 "hide": ["released"]
               }
             ]
         },
         ......
}

• Note: There is no UI to configure this for now. Possible only through JSON upload. What we have done is we introduced one property in settings "customTablePropertiesOfModal". Please refer above.
• The results will look like below image.

NOTICE:

The program was tested solely for our own use cases, which might differ from yours.
Author Info: Monish [email protected] on behalf of Mercedes-Benz Research and Development India
https://github.com/mercedes-benz/mercedes-benz-foss/blob/master/PROVIDER_INFORMATION.md

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (52426c8) 39.04% compared to head (5095a80) 39.04%.
Report is 22 commits behind head on develop.

Files	Patch %	Lines
...art/graph/component/GraphEntityInspectionTable.tsx	0.00%	18 Missing ⚠️
src/chart/bar/util.ts	0.00%	6 Missing ⚠️
src/application/logging/LoggingThunk.ts	0.00%	3 Missing ⚠️
...c/chart/graph/component/GraphChartInspectModal.tsx	75.00%	2 Missing ⚠️
src/chart/bar/BarChart.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #687      +/-   ##
===========================================
- Coverage    39.04%   39.04%   -0.01%     
===========================================
  Files          208      208              
  Lines         8718     8736      +18     
  Branches      2597     2604       +7     
===========================================
+ Hits          3404     3411       +7     
- Misses        5252     5264      +12     
+ Partials        62       61       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alfredorubin96]

This feature needs documentation about the dictionary definition in the config.

[sonarqubecloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[nielsdejong]

I think this is a really useful feature, but I think we should wait until there is a UI available to edit dictionary settings.

We already have a component for editing simple dictionaries (GraphChartEditModal.tsx) and can potentially re-use it. Once we have the dictionary-edit modal, we open it whenever someone selects a dictionary property from a report's advanced settings. Then, after adding docs we can merge this feature as well.

[alfredorubin96]

I tried it, some notes:

1. writing on the hide attribute cell, for the way it formats the text, it's prohibitive;
2. It doesn't look like it's working (tried both ordering and hiding props)