Skip to content

Commit

Permalink
fix: Throw an error on TERMINATED state
Browse files Browse the repository at this point in the history
  • Loading branch information
exaby73 committed Mar 10, 2025
1 parent b6d9ff7 commit 8bd3cc5
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/EventHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Neo4j\Neo4jBundle;

use http\Exception\UnexpectedValueException;
use Laudis\Neo4j\Databags\Statement;
use Laudis\Neo4j\Databags\SummarizedResult;
use Laudis\Neo4j\Enum\TransactionState;
Expand Down Expand Up @@ -167,7 +168,7 @@ private function createPreAndPostEventsAndIds(
),
PreTransactionBeginEvent::EVENT_ID,
],
TransactionState::TERMINATED, TransactionState::ROLLED_BACK => [
TransactionState::ROLLED_BACK => [
new PreTransactionRollbackEvent(
alias: $alias,
time: new \DateTimeImmutable(),
Expand All @@ -185,6 +186,7 @@ private function createPreAndPostEventsAndIds(
),
PreTransactionCommitEvent::EVENT_ID,
],
TransactionState::TERMINATED => throw new UnexpectedValueException('TERMINATED is not a valid transaction state at this point'),

Check failure on line 189 in src/EventHandler.php

View workflow job for this annotation

GitHub Actions / Lint & Analyse

UndefinedClass

src/EventHandler.php:189:55: UndefinedClass: Class, interface or enum named http\Exception\UnexpectedValueException does not exist (see https://psalm.dev/019)
};
[$postEvent, $postEventId] = match ($nextTransactionState) {
TransactionState::ACTIVE => [
Expand All @@ -196,7 +198,7 @@ private function createPreAndPostEventsAndIds(
),
PostTransactionBeginEvent::EVENT_ID,
],
TransactionState::TERMINATED, TransactionState::ROLLED_BACK => [
TransactionState::ROLLED_BACK => [
new PostTransactionRollbackEvent(
alias: $alias,
time: new \DateTimeImmutable(),
Expand All @@ -214,6 +216,7 @@ private function createPreAndPostEventsAndIds(
),
PostTransactionCommitEvent::EVENT_ID,
],
TransactionState::TERMINATED => throw new UnexpectedValueException('TERMINATED is not a valid transaction state at this point'),

Check failure on line 219 in src/EventHandler.php

View workflow job for this annotation

GitHub Actions / Lint & Analyse

UndefinedClass

src/EventHandler.php:219:55: UndefinedClass: Class, interface or enum named http\Exception\UnexpectedValueException does not exist (see https://psalm.dev/019)
};

return [
Expand Down

0 comments on commit 8bd3cc5

Please sign in to comment.