-
Notifications
You must be signed in to change notification settings - Fork 204
Add GitHub actions: windows unit tests #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9b2989 to
25e8a47
Compare
25e8a47 to
027d5ab
Compare
On windows only, the driver would re-write the DNS error when resolving `Address(None, None)` to be retryable, which it shouldn't.
MaxAake
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
be50f30 to
75e9ff7
Compare
robsdedude
added a commit
to robsdedude/neo4j-python-driver
that referenced
this pull request
Oct 21, 2025
* Adding GitHub Actions CI to run unit tests under Windows * Work around pytest on windows not liking long test ids
This was referenced Oct 21, 2025
robsdedude
added a commit
that referenced
this pull request
Oct 21, 2025
* Adding GitHub Actions CI to run unit tests under Windows * Work around pytest on windows not liking long test ids
robsdedude
added a commit
that referenced
this pull request
Oct 21, 2025
* Adding GitHub Actions CI to run unit tests under Windows * Work around pytest on windows not liking long test ids
robsdedude
added a commit
that referenced
this pull request
Oct 21, 2025
* Adding GitHub Actions CI to run unit tests under Windows * Work around pytest on windows not liking long test ids
robsdedude
added a commit
that referenced
this pull request
Oct 22, 2025
* Adding GitHub Actions CI to run unit tests under Windows * Work around pytest on windows not liking long test ids
robsdedude
added a commit
that referenced
this pull request
Oct 22, 2025
* Adding GitHub Actions CI to run unit tests under Windows * Work around pytest on windows not liking long test ids
robsdedude
added a commit
that referenced
this pull request
Oct 22, 2025
* Adding GitHub Actions CI to run unit tests under Windows * Work around pytest on windows not liking long test ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long parametrized test_input on Windows: ValueError: the environment variable is longer than 32767 characters pytest-dev/pytest#6881
👀️🪟️
On windows only, the driver would re-write the DNS error when resolving
Address(None, None)to be retryable, which it shouldn't.