Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeitwerk autoload fixes #1709

Merged
merged 3 commits into from
Dec 24, 2023
Merged

Zeitwerk autoload fixes #1709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffe4911
corrected gemfile generation
mrhardikjoshi Dec 24, 2023
6eec4b6
loaded active_graph in railtie
mrhardikjoshi Dec 24, 2023
514d9e4
removed commented code from gemfile
mrhardikjoshi Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@ source 'http://rubygems.org'

gemspec

# gem 'neo4j-ruby-driver', path: '../neo4j-ruby-driver'

# gem 'listen', '< 3.1'

active_model_version = ENV['ACTIVE_MODEL_VERSION']
gem 'activemodel', "~> #{active_model_version}" if active_model_version&.length&.positive?

Expand Down
2 changes: 1 addition & 1 deletion docs/activegraph.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Usage: rails new myapp -m activegraph.rb

gem 'activegraph', '=> 11.1'
gem 'activegraph', '>= 11.1'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated fresh rails application before and after this change to compare exact file difference after this change, here is its diff


gem_group :development do
gem 'neo4j-rake_tasks'
Expand Down
2 changes: 2 additions & 0 deletions lib/active_graph/railtie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
require 'active_graph'

module ActiveGraph
class Railtie < ::Rails::Railtie
def empty_config
Expand Down