Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Kubernetes 1.16+ #2

Merged
merged 2 commits into from
Dec 20, 2020
Merged

Update for Kubernetes 1.16+ #2

merged 2 commits into from
Dec 20, 2020

Conversation

jrissler
Copy link
Contributor

@jrissler jrissler commented Dec 19, 2020

Happy to fix any issues / change anything that I didn't do right, was learning Helm 3 at the same time :)

Solves #1

@jrissler jrissler marked this pull request as draft December 19, 2020 22:18
Copy link
Owner

@neoGeneva neoGeneva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jrissler, these changes looks pretty straight forward so I'll approve them.

I'm not sure I'll have the time to maintain this project (and I'm not sure anyone's even using it), so if you're keen to maintain it I can transfer ownership, or make you a contributor (I'm not sure which is best,) or I can just keep accepting pull-requests when I have time.

@neoGeneva
Copy link
Owner

Also, just so you know, this was a total learning project for me to, it was the first (and only time) I've written Go, so the whole thing certainly was an experience!

@neoGeneva neoGeneva marked this pull request as ready for review December 20, 2020 07:39
@neoGeneva neoGeneva merged commit 78988ae into neoGeneva:master Dec 20, 2020
@jrissler
Copy link
Contributor Author

@neoGeneva awesome thanks. That's impressive that you were able to put this together and learn Go at the same time!

I still have one more issue to work through - probably work on it next weekend. I don't think it's with your library - though I can't quite prove it's not lol. I ended up temporarily using http01 vs dns01

With a groupName of something like acme.mycompany.com in the ClusterIssuer (or Issuer) - everything goes well up till this error in GC: User "system:serviceaccount:cert-manager:cert-manager" cannot create resource "godaddy" in API group. The API group is it's trying to use is godaddy.acme.mycompany.com - I think this makes sense, somewhere you note it would be useful in case you had multiple resolvers. However not quite sure whether this is a RBAC issue (seems like it), or an issue with GC somewhere that can be resolved there. Any ideas?

I'm happy to help with ownership or contributor, whatever makes sense. I need to get these working for quite a few instances - so will def be in here for awhile and be re-using / keeping updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants