Support adding Editions to Works as required_resources #728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scraping a work for a site, I would like to add (selected) editions.
I assumed that I could just return editions in
pd.metadata["required_resources"]
. This works correctly when I add a work when scraping editions.Looking at the code this is due to a missing
Work.update_linked_items_from_external_resource()
method. This commits naively copies the implementation fromEdition.update_linked_items_from_external_resource()
.