Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding Editions to Works as required_resources #728

Merged
merged 3 commits into from
Jul 27, 2024

Conversation

pmakholm
Copy link

When scraping a work for a site, I would like to add (selected) editions.

I assumed that I could just return editions in pd.metadata["required_resources"]. This works correctly when I add a work when scraping editions.

Looking at the code this is due to a missing Work.update_linked_items_from_external_resource() method. This commits naively copies the implementation from Edition.update_linked_items_from_external_resource().

@alphatownsman alphatownsman merged commit 9763192 into neodb-social:main Jul 27, 2024
4 checks passed
@alphatownsman
Copy link
Member

Thanks, merged this. However, I suggest putting edition info in related_resources rather than required_resources in your work.scrape() code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants