-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand the configuration code example to give some more context #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Provided some thoughts on some of the syntax and flow in the rest of the document.
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall to me, requesting one change on top of Champ's comments.
Co-authored-by: IchHabeHunger54 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This article will probably be rewritten as a whole in the future, however for now this is definitely a good addition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw you marked my comments as resolved, but it seems like you ignored them. Would you mind giving some justification as to why?
Unsure why they weren't resolved, I think there was a missing commit, check the new commit though it should be in there, :)
|
I unresolved the two comments that weren't addressed. Could you please explain your decisions for these two (public constructor and non-public fields). |
Resolved the remaining issues |
I thought the code examples on this page were a bit short, so I've just extended it to help people get started with configs easier
Preview URL: https://pr-107.neoforged-docs-previews.pages.dev