Entity docs #171
Open
Entity docs #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dennis C <[email protected]>
Co-authored-by: Dennis C <[email protected]>
Co-authored-by: ChampionAsh5357 <[email protected]>
neoforged-automation
bot
added
the
needs rebase
|
@IchHabeHunger54, this pull request has conflicts, please resolve them for this PR to move forward. |
# Conflicts: # docs/resources/client/models/bakedmodel.md # docs/resources/server/conditions.md
neoforged-automation
bot
removed
the
needs rebase
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
ChampionAsh5357
requested changes
Feb 6, 2025
|
|
||
| As such, vanilla introduces a few systems to help with that. These systems generally exist in parallel and can be replaced with one another, this is due to legacy reasons. | ||
|
|
||
| ## `SynchedEntityData` |
There was a problem hiding this comment.
Going to unresolve and more specifically say that if you need to sync additional data from the entity, such as for data attachments, then you should create your own network packet to sync manually as required.
You can link to your data attachments section below.
| if (renderer != null) { | ||
| // Add the layer to the renderer. Like above, construct a new MyRenderLayer. | ||
| // The EntityModelSet can be retrieved from the event through #getEntityModels. | ||
| renderer.addLayer(new MyRenderLayer(renderer, event.getEntityModels())); |
There was a problem hiding this comment.
This would not compile due to the generics.
| // Get the associated PlayerRenderer. | ||
| if (event.getSkin(skin) instanceof PlayerRenderer playerRenderer) { | ||
| // Add the layer to the renderer. | ||
| playerRenderer.addLayer(new MyRenderLayer(playerRenderer, event.getEntityModels())); |
There was a problem hiding this comment.
This would not compile due to the generics differing between the layer and the renderer.
neoforged-automation
bot
added
the
needs rebase
|
@IchHabeHunger54, this pull request has conflicts, please resolve them for this PR to move forward. |
Gaming32
reviewed
Feb 18, 2025
# Conflicts: # docs/worldgen/biomemodifier.md
neoforged-automation
bot
removed
the
needs rebase
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some long-needed entity documentation. Supersedes #15 and #95 . Closes #82 . Closes #90 . This PR:
Preview URL: https://pr-171.neoforged-docs-previews.pages.dev