Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention how to target unregistered biomes #189

Merged

Conversation

TelepathicGrunt
Copy link
Contributor

@TelepathicGrunt TelepathicGrunt commented Nov 2, 2024

Was suggested in here to mention how to handle Pale Garden biome
neoforged/NeoForge#1649 (comment)


Preview URL: https://pr-189.neoforged-docs-previews.pages.dev

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) November 2, 2024 13:14 Active
@neoforged-pages-deployments
Copy link

neoforged-pages-deployments bot commented Nov 2, 2024

Deploying with Cloudflare Pages

Name Result
Last commit: 173d03970177f94aaf76b72ef1b1bea0eedabc39
Status: ✅ Deploy successful!
Preview URL: https://92ae2604.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-189.neoforged-docs-previews.pages.dev

Copy link
Member

@IchHabeHunger54 IchHabeHunger54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small nitpick.

docs/worldgen/biomemodifier.md Outdated Show resolved Hide resolved
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) November 2, 2024 14:38 Active
IchHabeHunger54
IchHabeHunger54 previously approved these changes Nov 2, 2024
Copy link
Member

@IchHabeHunger54 IchHabeHunger54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but merging only once #178 has been merged as well.

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) November 2, 2024 21:52 Active
@IchHabeHunger54 IchHabeHunger54 added the addition Adding or rewriting information. label Nov 9, 2024
@neoforged-automation neoforged-automation bot added the needs rebase This Pull Request needs to be rebased before being merged label Nov 15, 2024
@neoforged-automation
Copy link

@TelepathicGrunt, this pull request has conflicts, please resolve them for this PR to move forward.

@IchHabeHunger54
Copy link
Member

Rebase, then this should be good to go.

@IchHabeHunger54 IchHabeHunger54 enabled auto-merge (squash) November 15, 2024 23:25
auto-merge was automatically disabled November 16, 2024 14:14

Head branch was pushed to by a user without write access

@TelepathicGrunt TelepathicGrunt force-pushed the ExperimentalBiomeModifiers branch from 6c5b148 to 173d039 Compare November 16, 2024 14:14
@neoforged-automation neoforged-automation bot removed the needs rebase This Pull Request needs to be rebased before being merged label Nov 16, 2024
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) November 16, 2024 14:18 Active
@IchHabeHunger54 IchHabeHunger54 merged commit 26aac82 into neoforged:main Nov 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition Adding or rewriting information.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants