Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change feature flags default file location #198

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Change feature flags default file location #198

merged 1 commit into from
Nov 15, 2024

Conversation

ApexModder
Copy link
Contributor

@ApexModder ApexModder commented Nov 15, 2024 •
edited by neoforged-pages-deployments bot
Loading

Simply changes the default file location for feature flags

Preview URL: https://pr-198.neoforged-docs-previews.pages.dev

IchHabeHunger54
IchHabeHunger54 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@IchHabeHunger54 IchHabeHunger54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, we talked about how we should have all these extra JSONs be in META-INF instead of the project root for consistency.

@IchHabeHunger54 IchHabeHunger54 merged commit 7fe01bd into neoforged:main Nov 15, 2024
1 check passed
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) November 15, 2024 23:43 Active
@neoforged-pages-deployments
Copy link

Deploying with Cloudflare Pages

Name Result
Last commit: 1fdf7b5d908b8ef19d9895a965ac1a93435ec683
Status: ✅ Deploy successful!
Preview URL: https://35f9f6d0.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-198.neoforged-docs-previews.pages.dev

@ApexModder ApexModder deleted the pr/feature-flags-update branch November 16, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IchHabeHunger54 IchHabeHunger54 IchHabeHunger54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ApexModder @IchHabeHunger54