Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe type + reason introduced in NeoForge 20.4.40-beta #37

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Dec 16, 2023

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 16, 2023 21:52 Active
@neoforged-pages-deployments
Copy link

neoforged-pages-deployments bot commented Dec 16, 2023

Deploying with Cloudflare Pages

Name Result
Last commit: 7dd0f7bddab3a2c5306117fe15835528dcb2e426
Status: ✅ Deploy successful!
Preview URL: https://1e24e4b1.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-37.neoforged-docs-previews.pages.dev

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 16, 2023 21:55 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 16, 2023 21:56 Active
@IchHabeHunger54
Copy link
Member

Looks good in general. Three minor nitpicks:

  • Please remove the "Replaced the mandatory field in NeoForge 20.4.40-beta". We assume people reading the docs to be on latest NeoForge.
  • AFAICT the type value must be encased in "" (this is not the case in the example).
  • Please add a simple example for the reason, something like reason="This mod is not compatible with <other mod> because both touch rendering internals in a non-compatible way."

@shartte
Copy link
Contributor Author

shartte commented Dec 18, 2023

Looks good in general. Three minor nitpicks:

* Please remove the "Replaced the `mandatory` field in NeoForge 20.4.40-beta". We assume people reading the docs to be on latest NeoForge.

* AFAICT the type value must be encased in "" (this is not the case in the example).

* Please add a simple example for the reason, something like `reason="This mod is not compatible with <other mod> because both touch rendering internals in a non-compatible way."`

Did 1) and 2), but will not do 3) since I'll leave that up to further improvement ;)

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) December 18, 2023 18:01 Active
@IchHabeHunger54 IchHabeHunger54 merged commit e682e9d into neoforged:main Dec 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants