Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge SPI into loader sourceset #109

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

Technici4n
Copy link
Member

The separation does not bring much to the table, and is preventing us from cleaning up some APIs. For example, any mod language provider must instantiate ModContainer, and therefore must always depend on FML.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Apr 2, 2024

  • Publish PR to GitHub Packages

Last commit published: 01b2d387d71f3c24e6bc805c326fd3f97c69ab49.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #109' // https://github.com/neoforged/FancyModLoader/pull/109
        url 'https://prmaven.neoforged.net/FancyModLoader/pr109'
        content {
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
        }
    }
}

@Technici4n Technici4n merged commit 2dfe2ee into neoforged:main Apr 8, 2024
3 checks passed
@Technici4n Technici4n deleted the merge-spi branch April 8, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants