Improve hasErrors implementations

[embeddedt]

This PR fixes an issue where LoadingModList.hasErrors incorrectly returns true if there are actually no loading errors. The original logic of this method appears to be backwards, it returns true if none of the issues have a severity of ERROR.

Additionally, I made both LoadingModList.hasErrors() and ModLoader.hasErrors() check that the list of issues is non-empty before bothering to create a stream. This avoids unnecessary stream allocations in hot code in the very common case of there being no warnings or errors, and is trivial enough that it's harmless to add.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: e000ec2cb2dcd5c18380993cdcee5cee63bb6a13.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged.fancymodloader:earlydisplay:3.0.47-pr-159-fix-has-errors
• 📦 net.neoforged.fancymodloader:loader:3.0.47-pr-159-fix-has-errors
• 📦 net.neoforged.fancymodloader:junit-fml:3.0.47-pr-159-fix-has-errors

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #159' // https://github.com/neoforged/FancyModLoader/pull/159
        url 'https://prmaven.neoforged.net/FancyModLoader/pr159'
        content {
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
        }
    }
}

[shartte]

Quick 'n dirty JMH:

Benchmark                             Mode  Cnt           Score          Error  Units
AnyMatchVsIsEmpty.withEmptyCheck     thrpt    5  1466616037.872 � 16579783.035  ops/s
AnyMatchVsIsEmpty.withoutEmptyCheck  thrpt    5   110953698.193 �  7635053.997  ops/s