Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error reporting in dev #170

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Jun 24, 2024

  • This makes use of the changes in Refactor ModLoadingIssue Warning/Error Translations #167 to be able to freely convert a translation between error/warning
  • It now reports the full set of incompatibility issues as errors when in dev, instead of falling back to a generic "brokenfile" error as before
  • Added tests for more cases
  • Made it so that an unknown FMLModType is now reported as a normal incompatibility, using the following adjustment:
    • If a ModFileReader throws a ModLoadingException, the contained issues are recorded as incompatibilities and will be reported, if no other reader successfully reads the file. The reporting level will be inherited (warning in prod, error in dev)
    • Any other exception continues to be reported as a loading error

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jun 24, 2024

  • Publish PR to GitHub Packages

Last commit published: c73b537f51b6d59936321f8d2e335318264f01bb.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #170' // https://github.com/neoforged/FancyModLoader/pull/170
        url 'https://prmaven.neoforged.net/FancyModLoader/pr170'
        content {
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
        }
    }
}

@shartte shartte force-pushed the better-dev-errors branch 2 times, most recently from 68b645a to 1c4039e Compare June 24, 2024 16:40
@shartte shartte force-pushed the better-dev-errors branch from a39cc87 to c73b537 Compare July 2, 2024 16:18
@shartte shartte requested a review from Matyrobbrt July 2, 2024 16:39
@shartte shartte merged commit 1ec03f6 into neoforged:main Jul 4, 2024
3 checks passed
@shartte shartte deleted the better-dev-errors branch July 4, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants