Use ByteBuddy in unit tests to avoid having to add add-opens to unit tests

[shartte]

What it says on the tin :-)

We use the ByteBuddy agent implicitly already through Mockito.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: a84c04e67e087497239e6c93e4848384b20bbc34.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged.fancymodloader:junit-fml:4.0.14-pr-171-bytebuddy-add-opens
• 📦 net.neoforged.fancymodloader:earlydisplay:4.0.14-pr-171-bytebuddy-add-opens
• 📦 net.neoforged.fancymodloader:loader:4.0.14-pr-171-bytebuddy-add-opens

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #171' // https://github.com/neoforged/FancyModLoader/pull/171
        url 'https://prmaven.neoforged.net/FancyModLoader/pr171'
        content {
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'loader')
        }
    }
}

[SquidDev]

Apologies if you're already aware, but there's plans to disable dynamic loading of agents (and so ByteBuddyAgent.install) in the future — see JEP 451. This definitely doesn't matter right now, as NeoForged is pinned to Java 21, but worth bearing in mind for the future!

[shartte]

Apologies if you're already aware, but there's plans to disable dynamic loading of agents (and so ByteBuddyAgent.install) in the future — see JEP 451. This definitely doesn't matter right now, as NeoForged is pinned to Java 21, but worth bearing in mind for the future!

I am aware, yes. I do however think that the ecosystem will not stand this if it breaks use of Mocking frameworks in Gradle/IntelliJ (Mockito is a prominent example), so I am confident that either:

• They'll keep the XX flag to allow it
• They'll remove it only once Gradle/IJ actually improved their support to set the javaagent on the CLI for tests

In general the only thing really missing to drop the dynamic attach is IJ and Eclipse reading agent settings from Gradle.