Wayland early display window #187
Conversation
|
|
Just to clarify: this does not actually work unless you manually update GLFW To 3.4? |
|
the window will load up with wayland on GLFW 3.3+ (default for 1.20.1+), the icon won't load unless GLFW version 3.4+ (default for mc 1.21) is in use, everything else should work fine |
|
notably there is a GLFW error printed to the console |
|
I am against merging this like this, since it feels extremely convoluted to set a window icon using an externally written file & spawned process. There's apparently a Wayland proposal to be sane about setting window icons. Once that has been merged, I'd hope GLFW will just support this natively: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/269 Regardless of the window icon, setting the app_id is fine. The rest of it, I do not want a separate window provider for this. It feels unnecessary and just complicates the code.
Why is this actually necessary for Wayland support? p.s.: Anything that is actually necessary for basic support of Wayland seems to just require a few lines in the current earlydisplay provider, and we can do that. Enabling wayland, for example, could simply be done via CLI args. |
|
I will try to test this on WSL2 l. Wish me luck. |
| @@ -124,6 +127,7 @@ public Runnable initialize(String[] arguments) { | |||
| .withRequiredArg().ofType(Integer.class) | |||
| .defaultsTo(FMLConfig.getIntConfigValue(FMLConfig.ConfigValue.EARLY_WINDOW_HEIGHT)); | |||
| var maximizedopt = parser.accepts("earlywindow.maximized"); | |||
| var waylandopt = parser.accepts("earlywindow.wayland"); | |||
There was a problem hiding this comment.
I wonder if we should just call this wayland since it enables Wayland not only for the early display window, but for the entirety of the Minecraft session, right?
|
I think this is way easier to merge now. I'll test it out as soon as I can. |
|
Soooo.. |
After some testing, it seems that currently KDE Plasma incorrectly reports the Window as "not responding" on initial focus. After alt tabbing away and back onto the window this goes away. I assume that's what this hint is for. |
…ectly reporting the window as not responding
|
I had initially removed the hint after testing for that issue on my own system, I've added it back to see if it fixes the issue. |
Wayland early display window implementation, requested in #98