Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window icon not being set on startup. #204

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Sep 16, 2024

Fixes the NeoForge icon not correctly being set since the put advanced the buffer thus making LWJGL think the icon array is empty.

image

image

p.s.: the icon will switch back to a Minecraft icon as normal when Vanilla takes over.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Sep 16, 2024

  • Publish PR to GitHub Packages

Last commit published: b62367488b6ce8bdf16b2132365f297bf1042fd1.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #204' // https://github.com/neoforged/FancyModLoader/pull/204
        url 'https://prmaven.neoforged.net/FancyModLoader/pr204'
        content {
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'tests')
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
        }
    }
}

Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.

@sciwhiz12 sciwhiz12 added the bug Something isn't working label Sep 16, 2024
@shartte shartte merged commit cf7f3db into neoforged:main Sep 17, 2024
4 checks passed
@shartte shartte deleted the window-icon branch September 17, 2024 13:27
@neoforged-releases
Copy link

🚀 This PR has been released as FancyModLoader version 4.0.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants