Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up default config writing #218

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Technici4n
Copy link
Member

  • Get rid of the CommentedFileConfig in favor of explicitly reading and writing a config.
  • Always use a LinkedHashMap as the backend of a config when it affects ordering.
  • Get rid of defaultfmlconfig.toml, and replace it by just correcting an empty config.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 24, 2024

  • Publish PR to GitHub Packages

Last commit published: 0d7b926f8e4f3fbb85a0e3d516ac3d35bf19fd92.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #218' // https://github.com/neoforged/FancyModLoader/pull/218
        url 'https://prmaven.neoforged.net/FancyModLoader/pr218'
        content {
            includeModule('net.neoforged.fancymodloader', 'tests')
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
        }
    }
}

@Matyrobbrt Matyrobbrt merged commit be57775 into neoforged:main Nov 25, 2024
4 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as FancyModLoader version 5.0.5.

Matyrobbrt pushed a commit to Matyrobbrt/FancyModLoader that referenced this pull request Nov 25, 2024
Technici4n added a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants