Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source info for JarInJar mod #82

Closed
wants to merge 7 commits into from
Closed

Add source info for JarInJar mod #82

wants to merge 7 commits into from

Conversation

TT432
Copy link

@TT432 TT432 commented Jan 27, 2024

I tried to add the trace of the JarInJar mod to be able to print out the source of the JarInJar mod, which is useful for debugging in some complex environments, such as some environments with dozens of mods, because some non-standard packaging behavior or wrong java module definition causes conflicts or even crashes, in this case I need to find out the source of JarInJar to help identify the problem.

@sciwhiz12 sciwhiz12 added the enhancement New feature or request label Feb 11, 2024
@marchermans
Copy link
Contributor

In general this is a way to solve it yes.
Not sure if I like the marking mechanism since you can get the same information from the uri of the jar in jar system. But a possible solution for sure.

@TT432
Copy link
Author

TT432 commented Feb 23, 2024

I've made changes to try printing the URI in the handleLocatedFiles, but my Git skills are not very good and my commits are a bit messy. Do I need to open a new pull request?

@Technici4n
Copy link
Member

We will squash, no worries.

@shartte
Copy link
Contributor

shartte commented Apr 20, 2024

I'll close this as I've built this in with the locator rewrite in #112

Example log output:

[19:45:26] [main/INFO] [ne.ne.fm.lo.mo.ModDiscoverer/SCAN]: Found mod file "jijmod.jar" of type MOD with provider net.neoforged.fml.loading.moddiscovery.locators.JarModsDotTomlModFileReader@7d44a19
[19:45:26] [main/INFO] [ne.ne.fm.lo.mo.ModDiscoverer/SCAN]: Found mod file "embedded_mod-1.0.jar" of type MOD with provider net.neoforged.fml.loading.moddiscovery.locators.JarModsDotTomlModFileReader@7d44a19 contained in jijmod.jar
[19:45:26] [main/INFO] [ne.ne.fm.lo.mo.ModDiscoverer/SCAN]: Found mod file "embedded_service-1.0.jar" of type LIBRARY with provider net.neoforged.fml.loading.moddiscovery.locators.JarModsDotTomlModFileReader@7d44a19 contained in jijmod.jar
[19:45:26] [main/INFO] [ne.ne.fm.lo.mo.ModDiscoverer/SCAN]: Found mod file "embedded_gamelib-1.0.jar" of type GAMELIBRARY with provider net.neoforged.fml.loading.moddiscovery.locators.JarModsDotTomlModFileReader@7d44a19 contained in jijmod.jar
[19:45:26] [main/INFO] [ne.ne.fm.lo.mo.ModDiscoverer/SCAN]: Found mod file "embedded_lib-1.0.jar" of type LIBRARY with provider net.neoforged.fml.loading.moddiscovery.providers.NestedLibraryModProvider@1716e8c5 contained in jijmod.jar

(ìgnore the longer classname in there, the key part is the "contained in" at the end)

@shartte shartte closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants