-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source info for JarInJar mod #82
Conversation
In general this is a way to solve it yes. |
I've made changes to try printing the URI in the handleLocatedFiles, but my Git skills are not very good and my commits are a bit messy. Do I need to open a new pull request? |
We will squash, no worries. |
I'll close this as I've built this in with the locator rewrite in #112 Example log output:
(ìgnore the longer classname in there, the key part is the "contained in" at the end) |
I tried to add the trace of the JarInJar mod to be able to print out the source of the JarInJar mod, which is useful for debugging in some complex environments, such as some environments with dozens of mods, because some non-standard packaging behavior or wrong java module definition causes conflicts or even crashes, in this case I need to find out the source of JarInJar to help identify the problem.