Only log errors when scanning mod file contents #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing a debug-level log for every file path is problematic for two reasons:
debug.log
file, as there's a huge quantity of lines from the scanner at the beginning.Snippet from profiler showing the bottleneck:
This information isn't that useful to log in bulk since one could just examine the mod JAR manually to know what files it contains. Instead, we just log if an exception occurs while scanning a given path.