-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registerConfig
method to ModContainer
#99
Conversation
|
I would also add the method to change the filename of the config and redirect the |
Yeah, I don't see why not. Aside from that, should anything be done with the validation currently in the |
Since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move the isEmpty
check to the new methods as well, and deprecate the old methods for removal?
Adds a method to
ModContainer
to create and add a mod config from a given type and spec. This is added to simplify the current verboseaddConfig
method. I understand that the config system is currently being looked at for a future refactor and as such recognize that the lifetime of this method may be short.