Fix named attributes in legacy failing when reading back data from Module Metadata

[shartte]

We current have a bug where depending on a Mod that was published by MDG Legacy fails, due to that Mod containing our mappings attribute with the value "srg".

Gradle seems to be unable to map that back for some reason.

* What went wrong:
Execution failed for task ':compileKotlin'.
> Could not resolve all files for configuration ':compileClasspath'.
   > Could not resolve dev.icosider:dripper-forge:1.20.1-1.0.0.
     Required by:
         root project :
      > No enum constant net.neoforged.moddevgradle.legacyforge.internal.MinecraftMappings.srg

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: d7affafcb0aaa5da1cc75508ad489241677e3d82.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged.moddev:net.neoforged.moddev.gradle.plugin:2.0.82-pr-225-named-attrs-legacy
• 📦 net.neoforged:moddev-gradle:2.0.82-pr-225-named-attrs-legacy
• 📦 net.neoforged.moddev.repositories:net.neoforged.moddev.repositories.gradle.plugin:2.0.82-pr-225-named-attrs-legacy
• 📦 net.neoforged.moddev.legacyforge:net.neoforged.moddev.legacyforge.gradle.plugin:2.0.82-pr-225-named-attrs-legacy

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #225' // https://github.com/neoforged/ModDevGradle/pull/225
        url 'https://prmaven.neoforged.net/ModDevGradle/pr225'
        content {
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
            includeModule('net.neoforged', 'moddev-gradle')
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
            includeModule('net.neoforged.moddev.legacyforge', 'net.neoforged.moddev.legacyforge.gradle.plugin')
        }
    }
}

[Icosider]

The fix is working, I just checked it myself. Thanks

[Icosider]

The fix, as it turned out, partially works. The dependency is added, but the reobf call does not occur, thus the game starts with the SRG version of the mod, and not its reobf version.

[shartte]

@Icosider Can you try again with the latest version of this PR?

[Icosider]

@shartte, It seems to be working pretty well. But at the moment, publishing to maven using multiple reobfuscate(task, sourceSet) remains problematic(perhaps it will relate to another PR)

[shartte]

Yes the publishing side is another story and unaffected by this.

[shartte]

@Matyrobbrt Can you review?

[neoforged-releases]

🚀 This PR has been released as ModDevGradle version 2.0.75.