Fix too many overlay breaking item and screen rendering (#1504 and #1553) #1555
+56
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
XFactHD
added
bug
|
@XFactHD In the newest push, Z-compressing now becomes opt-in. I call it at the beginning of This would effectively reduce draw calls from 1 per later to 2 in total by default. Hope this would address your concern regarding performance. |
|
@lcy0x1, this pull request has conflicts, please resolve them for this PR to move forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1504
Fix #1553
Issue #1504 is caused by having too many overlays translate the far plane too far off.
Issue #1553 is caused by having too many overlays before hotbar translating z-axis too high and cause floating point underflow.
This PR use depth-overwrite technique to allow overlays to be rendered at the same depth, so that it eliminates the need for overlays to be translated 200 units in Z for every overlay.
Removing Z-translation fix 1553, and stop overlay count from affecting farPlane fix 1504