[1.21.3] Fix blocks sometimes missing ambient occlusion #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XFactHD
added
bug
Last commit published: d146bf9d1b9e6dc1b79737e57e7aafaaf158e7a4. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1618' // https://github.com/neoforged/NeoForge/pull/1618
url 'https://prmaven.neoforged.net/NeoForge/pr1618'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
}MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1618
cd NeoForge-pr1618
curl -L https://prmaven.neoforged.net/NeoForge/pr1618/net/neoforged/neoforge/21.3.2-beta-pr-1618-block_shadows/mdk-pr1618.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zipTo test a production environment, you can download the installer from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes blocks sometimes missing ambient occlusion on a vertical or horizontal face (depends on orientation).
The caveat behind this fix is that it reverts the AO fix implemented in #1370, which is why I'm opening this as a draft for now.
Fixes #1613.