Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biome modifer crash with pale gardens #1649

Closed
MincraftEinstein opened this issue Oct 31, 2024 · 3 comments
Closed

Biome modifer crash with pale gardens #1649

MincraftEinstein opened this issue Oct 31, 2024 · 3 comments
Labels
triage Needs triaging and confirmation

Comments

@MincraftEinstein
Copy link

MincraftEinstein commented Oct 31, 2024

Minecraft Version: 1.21.3

NeoForge Version: 21.3.6-beta

Logs: crash-2024-10-30_16.35.35-client.txt

Steps to Reproduce:

  1. Create a biome modifier with the biome set to the pale garden
  2. Run the game
  3. Open the Create New World screen

Description of issue:
If you add a biome modifier for the pale garden biome the game will crash when opening the create new world screen because the biome is not enabled

@MincraftEinstein MincraftEinstein added the triage Needs triaging and confirmation label Oct 31, 2024
@TelepathicGrunt
Copy link
Contributor

Can you please show exactly how you setup the Biome Modifier? Have you tried using a biome tag with Pale Garden as an optional entry and then use that tag for the Biome Modifier and see if that doesn't crash?

@TelepathicGrunt
Copy link
Contributor

I made a test datapack doing what I described with an optional tag entry. I verified that does add forest rock feature to Pale Gardens just fine when the biome is activated so I know the biome modifier is loaded in and working. Then I tried again in a world with Pale Garden turned off and the datapack does not crash
test.zip
Image

I'm leaning towards your Biome Modifier is not setup properly to handle experimental biomes. Please try my suggested setup and if it works, we can close this issue report as working as intended.

@MincraftEinstein
Copy link
Author

Yes, using an optional tag fixes it. Perhaps this should be mentioned as a workaround for disabled biomes on the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triaging and confirmation
Projects
None yet
Development

No branches or pull requests

2 participants