Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack overlays in mod files are not supported #381

Closed
Apollounknowndev opened this issue Dec 13, 2023 · 4 comments
Closed

Pack overlays in mod files are not supported #381

Apollounknowndev opened this issue Dec 13, 2023 · 4 comments
Labels
1.20 Targeted at Minecraft 1.20 bug A bug or error

Comments

@Apollounknowndev
Copy link

Apollounknowndev commented Dec 13, 2023

Minecraft Version: 1.20.2+

NeoForge Version: any

Description of issue: Pack overlays in mod pack.mcmeta files do not function. This is a major issue for datapacks-packaged-as-mods which rely on overlays to function correctly on new versions, such as Terralith.

Steps to Reproduce

  • Install Terralith v2.4.11. This version of Terralith relies on pack overlays to support the minecraft:grass -> minecraft:short_grass change.
  • Attempt to create a new world. The game will instantly crash due to errors with registries failing the load, which is due to the game still trying to parse the files with minecraft:grass in them.
@Apollounknowndev Apollounknowndev added the triage Needs triaging and confirmation label Dec 13, 2023
@KnightMiner
Copy link
Contributor

KnightMiner commented Dec 13, 2023

I assume #367 already addresses this issue. Due to the nature of the fix will require being part of a breaking changes window.

@lukebemish
Copy link
Contributor

lukebemish commented Dec 13, 2023

If #367 doesn't already address this issue I will be making sure it does before it's merged (which should be pretty easy if it doesn't already support it out of the box - it's supposed to but it's also untested so I might need to fix s thing or two) - avoiding this sort of issue is a major goal of that PR

@XFactHD XFactHD added bug A bug or error 1.20 Targeted at Minecraft 1.20 and removed triage Needs triaging and confirmation labels Dec 13, 2023
@lukebemish
Copy link
Contributor

Just tested locally and #367 does seem to fix this - at least, making the terralith jar use lowcodefml so that it would load, then loading it locally with that PR, loaded and generated a world with the overlays applied correctly.

@XFactHD
Copy link
Member

XFactHD commented Dec 14, 2023

Fixed by #367

@XFactHD XFactHD closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 Targeted at Minecraft 1.20 bug A bug or error
Projects
None yet
Development

No branches or pull requests

4 participants