[1.20.4] Change how resource pack grouping works and group mod data packs - take 2 #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciwhiz12
added
enhancement
lukebemish
changed the title
Technici4n
reviewed
Dec 13, 2023
|
Testing locally, this seems to fix #381 - I'm able to correctly load a mod that uses overlays. Is it worth adding some sort of test cases for this somewhere? Not sure how tests work in neoforge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #138
Basically, the current approach of grouping resources packs has some... quirks. First of all, it requires extensive, sometimes non-obvious special-casing when iterating available packs or PackResources. Second of all, it doesn't play nice with modern resource pack tools added by mojang in recent versions, such as overlays or filters. Finally, it does not group datapacks, or ensure consistent ordering of datapacks that isn't dependent on the order mods are added to a world. This PR is an attempt to solve these problems.
It is accompanied by neoforged/NeoForgeSPI#1 and neoforged/FancyModLoader#21, to allow mods to opt out of their resources being grouped, and will need updated once those are merged.