-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an incompatible/discouraged clause to mod dependency #386
Conversation
Can you give an example of the syntax (I assume in mods.toml) to declare such an incompatibly? |
The [[dependencies.somemod]]
modId="othermod"
versionRange="[1,)"
- mandatory=false
+ type="optional" As for the incompatibility declaration: [[dependencies.neotests]]
type="discouraged" # can be "incompatible"
modId="client_command_test"
versionRange="[1.4.3,)"
reason="We conflict because of reasons" The version range can be omitted which will declare an incompatibility with all versions of the mod. |
eh I'm not really sure if I like the name |
The name is descriptive, it's quite literally what the feature does. It shows a screen discouraging the use of the mod. We've gone through different names and found this pair the best possible name, that also isn't extremely generic like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dewit
Depends on neoforged/FancyModLoader#51
More information can be found in that PR.