Update to simpler mod loading from latest FML

[Technici4n]

See neoforged/FancyModLoader#110.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: ec5b1f2723752abee6c74be10ad6eb69ae9e3c6e.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:20.5.0-alpha.1.20.5-rc1.20240418.193017
• 📦 net.neoforged:testframework:20.5.0-alpha.1.20.5-rc1.20240418.193017

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #774' // https://github.com/neoforged/NeoForge/pull/774
        url 'https://prmaven.neoforged.net/NeoForge/pr774'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr774.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr774
cd NeoForge-pr774
curl -L https://prmaven.neoforged.net/NeoForge/pr774/net/neoforged/neoforge/20.5.0-alpha.1.20.5-rc1.20240418.193017/mdk-pr774.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[shartte]

Comment when this is called? Or when it should be called?
Especially to explain why we have begin and load and why are they split?

[Technici4n]

I added a vague comment - the current separation is only an artifact of how we do part of the mod loading inside a reload listener (which introduces its own set of problems btw...). I don't really want to encode it because we have discussed a potential rework of the client mod init timings.

[shartte]

Why?