Skip to content

Commit

Permalink
⚙ Added better error handling for missing chart data
Browse files Browse the repository at this point in the history
  • Loading branch information
neoground committed Mar 25, 2021
1 parent 95b05a2 commit edd5c3a
Show file tree
Hide file tree
Showing 9 changed files with 57 additions and 16 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Cloudbase chart
- Chart titles can be changed
- Better error handling if data isn't available for a chart

### Fixed

Expand Down
9 changes: 7 additions & 2 deletions src/index.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,13 @@
#end if

#for $record in $span($day_delta=1).spans(interval=current_interval)
#set val = $getattr($record, $name)
[$record.start.raw, $getattr($val, $column).format(add_label=False, localize=False, None_string="null")],
#try
#set val = $getattr($record, $name)
#set data = $getattr($val, $column).format(add_label=False, localize=False, None_string="null")
[$record.start.raw, $data],
#except

#end try
#end for
#end def

Expand Down
9 changes: 7 additions & 2 deletions src/month-%Y-%m.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,13 @@

#def getChartData($name, $column)
#for $record in $month.days
#set val = $getattr($record, $name)
[$record.start.raw, $getattr($val, $column).format(add_label=False, localize=False, None_string="null")],
#try
#set val = $getattr($record, $name)
#set data = $getattr($val, $column).format(add_label=False, localize=False, None_string="null")
[$record.start.raw, $data],
#except

#end try
#end for
#end def

Expand Down
9 changes: 7 additions & 2 deletions src/month.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,13 @@
#end if

#for $record in $span($month_delta=1).spans(interval=current_interval)
#set val = $getattr($record, $name)
[$record.start.raw, $getattr($val, $column).format(add_label=False, localize=False, None_string="null")],
#try
#set val = $getattr($record, $name)
#set data = $getattr($val, $column).format(add_label=False, localize=False, None_string="null")
[$record.start.raw, $data],
#except

#end try
#end for
#end def

Expand Down
9 changes: 7 additions & 2 deletions src/telemetry.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,13 @@
#def getChartData($name, $column)
#set current_interval = int($Extras.Charts.current_timespan)
#for $record in $span($day_delta=1).spans(interval=current_interval)
#set val = $getattr($record, $name)
[$record.start.raw, $getattr($val, $column).format(add_label=False, localize=False, None_string="null")],
#try
#set val = $getattr($record, $name)
#set data = $getattr($val, $column).format(add_label=False, localize=False, None_string="null")
[$record.start.raw, $data],
#except

#end try
#end for
#end def

Expand Down
9 changes: 7 additions & 2 deletions src/week.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,13 @@
#end if

#for $record in $span($week_delta=1).spans(interval=current_interval)
#set val = $getattr($record, $name)
[$record.start.raw, $getattr($val, $column).format(add_label=False, localize=False, None_string="null")],
#try
#set val = $getattr($record, $name)
#set data = $getattr($val, $column).format(add_label=False, localize=False, None_string="null")
[$record.start.raw, $data],
#except

#end try
#end for
#end def

Expand Down
9 changes: 7 additions & 2 deletions src/year-%Y.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,13 @@

#def getChartData($name, $column)
#for $record in $year.days
#set val = $getattr($record, $name)
[$record.start.raw, $getattr($val, $column).format(add_label=False, localize=False, None_string="null")],
#try
#set val = $getattr($record, $name)
#set data = $getattr($val, $column).format(add_label=False, localize=False, None_string="null")
[$record.start.raw, $data],
#except

#end try
#end for
#end def

Expand Down
9 changes: 7 additions & 2 deletions src/year.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,13 @@
#end if

#for $record in $span($year_delta=1).spans(interval=current_interval)
#set val = $getattr($record, $name)
[$record.start.raw, $getattr($val, $column).format(add_label=False, localize=False, None_string="null")],
#try
#set val = $getattr($record, $name)
#set data = $getattr($val, $column).format(add_label=False, localize=False, None_string="null")
[$record.start.raw, $data],
#except

#end try
#end for
#end def

Expand Down
9 changes: 7 additions & 2 deletions src/yesterday.html.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,13 @@
#end if

#for $record in $span($hour_delta=48).spans(interval=current_interval)
#set val = $getattr($record, $name)
[$record.start.raw, $getattr($val, $column).format(add_label=False, localize=False, None_string="null")],
#try
#set val = $getattr($record, $name)
#set data = $getattr($val, $column).format(add_label=False, localize=False, None_string="null")
[$record.start.raw, $data],
#except

#end try
#end for
#end def

Expand Down

0 comments on commit edd5c3a

Please sign in to comment.