Skip to content

DeleteAction now also accepts a promise #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- DeleteAction now also accepts a promise

## [2.0.2] - 2022-04-14

### Fixed
Expand Down
14 changes: 10 additions & 4 deletions src/DeleteAction/DeleteAction.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ interface DeleteActionProps {
deleteButtonText?: string;
cancelButtonText?: string;
iconOnly?: boolean;
onDelete: () => void;
onDelete: () => void | Promise<boolean>;
}

function DeleteAction({
Expand Down Expand Up @@ -39,9 +39,15 @@ function DeleteAction({
<ModalFooter>
<Button
color="danger"
onClick={() => {
onDelete();
toggle();
onClick={async () => {
if (onDelete instanceof Promise) {
if (await onDelete()) {
toggle();
}
} else {
onDelete();
toggle();
}
}}
>
{deleteButtonText}
Expand Down