attempt 2: upgrade jest to fix broken tests due to modules imports #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I narrow changes here only to upgrading jest, and related changes. As I updated only devDependencies that shouldn't affect production container, although could be worth to update versions later. @antelman107 can you take a look? |
antelman107
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That fixes error with
test/webhooks.test.ts:Issue was due to some packages started to use
require("node:path")imports format, that wasn't support by Jest 26.It was addressed and fixed in jestjs/jest#11637, so upgrading Jest would work there.
In previous attempt I mixed
npmandyarn, so result was broken. Now just limit changes to jest only and useyarn install.