storage-controller: remove unused vars, cleanup documentation #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to know the console URL or API keys since #113, however, there's still some cleanup left. The `CONSOLE_URL` variable is not used in `register-storage-controller.py` (except for logging), so we can delete it and don't need to set it in the registration job either. Similarly, API keys are not needed, remove references in values files and documentation. Bump to version to 1.5.1, as this should be consired a bugfix to perform some belated cleanup.
VladLazar
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to know the console URL or API keys since
#113, however, there's still some cleanup left.
The
CONSOLE_URLvariable is not used inregister-storage-controller.py(except for logging), sowe can delete it and don't need to set it in the registration job either.
Similarly, API keys are not needed, remove references in values files and documentation.
Bump to version to 1.5.1, as this should be consired a bugfix to perform some belated cleanup.