Skip to content

Commit

Permalink
Do not reload config file on PS reconnect (#10204)
Browse files Browse the repository at this point in the history
## Problem

See #10184
and
https://neondb.slack.com/archives/C04DGM6SMTM/p1733997259898819

Reloading config file inside parallel worker cause it's termination

## Summary of changes

Remove call of `HandleMainLoopInterrupts()` 
Update of page server URL is propagated by postmaster through shared
memory and we should not reload config for it.

Co-authored-by: Konstantin Knizhnik <[email protected]>
  • Loading branch information
knizhnik and Konstantin Knizhnik authored Dec 19, 2024
1 parent 628451d commit 04517c6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pgxn/neon/libpagestore.c
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,6 @@ pageserver_send(shardno_t shard_no, NeonRequest *request)
{
while (!pageserver_connect(shard_no, shard->n_reconnect_attempts < max_reconnect_attempts ? LOG : ERROR))
{
HandleMainLoopInterrupts();
shard->n_reconnect_attempts += 1;
}
shard->n_reconnect_attempts = 0;
Expand Down

1 comment on commit 04517c6

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7245 tests run: 6937 passed, 1 failed, 307 skipped (full report)


Failures on Postgres 16

  • test_storage_controller_many_tenants[github-actions-selfhosted]: release-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_storage_controller_many_tenants[release-pg16-github-actions-selfhosted]"
Flaky tests (3)

Postgres 17

Postgres 16

Postgres 14

Code coverage* (full report)

  • functions: 31.2% (8394 of 26876 functions)
  • lines: 47.9% (66638 of 139015 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
04517c6 at 2024-12-19T17:36:12.811Z :recycle:

Please sign in to comment.