Skip to content

Commit

Permalink
fix(storage-scrubber): valid layermap error degrades to warning (#9902)
Browse files Browse the repository at this point in the history
Valid layer assumption is a necessary condition for a layer map to be
valid. It's a stronger check imposed by gc-compaction than the actual
valid layermap definition. Actually, the system can work as long as
there are no overlapping layer maps. Therefore, we degrade that into a
warning.

Signed-off-by: Alex Chi Z <[email protected]>
  • Loading branch information
skyzh authored Nov 27, 2024
1 parent e4f437a commit 23f5a27
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion storage_scrubber/src/checks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ pub(crate) async fn branch_cleanup_and_check_errors(

let layer_names = index_part.layer_metadata.keys().cloned().collect_vec();
if let Some(err) = check_valid_layermap(&layer_names) {
result.errors.push(format!(
result.warnings.push(format!(
"index_part.json contains invalid layer map structure: {err}"
));
}
Expand Down

1 comment on commit 23f5a27

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7053 tests run: 6719 passed, 1 failed, 333 skipped (full report)


Failures on Postgres 16

  • test_sharded_ingest[github-actions-selfhosted-vanilla-1]: release-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sharded_ingest[release-pg16-github-actions-selfhosted-vanilla-1]"
Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 30.6% (7983 of 26062 functions)
  • lines: 48.6% (63357 of 130455 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
23f5a27 at 2024-11-27T18:41:17.757Z :recycle:

Please sign in to comment.