Skip to content

Commit

Permalink
test: Poll pageserver availability more aggressively at test startup
Browse files Browse the repository at this point in the history
Even with the 100 ms interval, on my laptop the pageserver always
becomes available on second attempt, so this saves about 900 ms at
every test startup.
  • Loading branch information
hlinnaka committed Sep 24, 2024
1 parent 589594c commit 2f7ceca
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test_runner/fixtures/neon_fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -2553,7 +2553,7 @@ def poll_node_status(
desired_availability: Optional[PageserverAvailability],
desired_scheduling_policy: Optional[PageserverSchedulingPolicy],
max_attempts: int,
backoff: int,
backoff: float,
):
"""
Poll the node status until it reaches 'desired_scheduling_policy' and 'desired_availability'
Expand Down Expand Up @@ -2948,7 +2948,7 @@ def start(
self.id
):
self.env.storage_controller.poll_node_status(
self.id, PageserverAvailability.ACTIVE, None, max_attempts=20, backoff=1
self.id, PageserverAvailability.ACTIVE, None, max_attempts=200, backoff=0.1
)

return self
Expand Down

1 comment on commit 2f7ceca

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5074 tests run: 4898 passed, 2 failed, 174 skipped (full report)


Failures on Postgres 16

  • test_compaction_l0_memory[github-actions-selfhosted]: release-x86-64
  • test_gc_feedback_with_snapshots[github-actions-selfhosted]: release-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_compaction_l0_memory[release-pg16-github-actions-selfhosted] or test_gc_feedback_with_snapshots[release-pg16-github-actions-selfhosted]"
Flaky tests (4)

Postgres 17

Postgres 15

Code coverage* (full report)

  • functions: 32.1% (7471 of 23243 functions)
  • lines: 50.0% (60205 of 120505 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2f7ceca at 2024-09-24T17:26:56.496Z :recycle:

Please sign in to comment.