Skip to content

Commit

Permalink
CI(build-build-tools): fix unexpected cancellations (#9357)
Browse files Browse the repository at this point in the history
## Problem
When `Dockerfile.build-tools` gets changed, several PRs catch up with
it and some might get unexpectedly cancelled workflows because of
GitHub's concurrency model for workflows.
See the comment in the code for more details.

It should be possible to revert it after
https://github.com/orgs/community/discussions/41518 (I don't expect it
anytime soon, but I subscribed)

## Summary of changes
- Do not queue `build-build-tools-image` workflows in the concurrency
group
  • Loading branch information
bayandin authored Oct 14, 2024
1 parent d056ae9 commit 31b7703
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions .github/workflows/build-build-tools-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,16 @@ defaults:
run:
shell: bash -euo pipefail {0}

concurrency:
group: build-build-tools-image-${{ inputs.image-tag }}
cancel-in-progress: false
# The initial idea was to prevent the waste of resources by not re-building the `build-tools` image
# for the same tag in parallel workflow runs, and queue them to be skipped once we have
# the first image pushed to Docker registry, but GitHub's concurrency mechanism is not working as expected.
# GitHub can't have more than 1 job in a queue and removes the previous one, it causes failures if the dependent jobs.
#
# Ref https://github.com/orgs/community/discussions/41518
#
# concurrency:
# group: build-build-tools-image-${{ inputs.image-tag }}
# cancel-in-progress: false

# No permission for GITHUB_TOKEN by default; the **minimal required** set of permissions should be granted in each job.
permissions: {}
Expand Down

1 comment on commit 31b7703

@github-actions
Copy link

@github-actions github-actions bot commented on 31b7703 Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5289 tests run: 5071 passed, 1 failed, 217 skipped (full report)


Failures on Postgres 16

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_storage_controller_heartbeats[release-pg16-failure0]"
Flaky tests (3)

Postgres 16

Postgres 14

Code coverage* (full report)

  • functions: 31.4% (7546 of 24027 functions)
  • lines: 49.2% (60359 of 122711 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
31b7703 at 2024-10-14T13:02:45.395Z :recycle:

Please sign in to comment.