Skip to content

Commit

Permalink
Increase shared_buffers in test_subscriber_synchronous_commit. (#9427)
Browse files Browse the repository at this point in the history
Might make the test less flaky.
  • Loading branch information
arssher authored Oct 18, 2024
1 parent b7173b1 commit 98fee7a
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions test_runner/regress/test_logical_replication.py
Original file line number Diff line number Diff line change
Expand Up @@ -558,10 +558,10 @@ def check_caughtup():
return publisher_flush_lsn


# Test that subscriber takes into account quorum committed flush_lsn in
# flush_lsn reporting to publisher. Without this, it may ack too far, losing
# data on restart because publisher advances START_REPLICATION position to the
# confirmed_flush_lsn of the slot.
# Test that neon subscriber takes into account quorum committed flush_lsn in
# flush_lsn reporting to publisher. Without this, subscriber may ack too far,
# losing data on restart because publisher implicitly advances positition given
# in START_REPLICATION to the confirmed_flush_lsn of the slot.
def test_subscriber_synchronous_commit(neon_simple_env: NeonEnv, vanilla_pg):
env = neon_simple_env
# use vanilla as publisher to allow writes on it when safekeeper is down
Expand All @@ -578,7 +578,10 @@ def test_subscriber_synchronous_commit(neon_simple_env: NeonEnv, vanilla_pg):
vanilla_pg.safe_psql("create extension neon;")

env.create_branch("subscriber")
sub = env.endpoints.create("subscriber")
# We want all data to fit into shared_buffers because later we stop
# safekeeper and insert more; this shouldn't cause page requests as they
# will be stuck.
sub = env.endpoints.create("subscriber", config_lines=["shared_buffers=128MB"])
sub.start()

with vanilla_pg.cursor() as pcur:
Expand Down

1 comment on commit 98fee7a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5220 tests run: 5004 passed, 2 failed, 214 skipped (full report)


Failures on Postgres 14

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_large_records[release-pg14-cross-validation] or test_replication_shutdown[release-pg14-cross-validation]"
Flaky tests (3)

Postgres 17

Postgres 14

Test coverage report is not available

The comment gets automatically updated with the latest test results
98fee7a at 2024-10-18T11:29:17.272Z :recycle:

Please sign in to comment.